Partially cleanup inc_curr_1vb_split
#375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMcClung
force-pushed
the
pr/some-curr-cleanup
branch
from
36d1766 to
b76d690
Compare
germasch
approved these changes
Jan 21, 2026
Contributor
germasch
left a comment
germasch
left a comment
There was a problem hiding this comment.
👍
As you were replacing gt::sarray with Vec3, this kinda reminded me that actually it'd be great to have Vec3 to just be an alias for the former. Eventually, as usual, with some specific exceptions (like cross really only makes sense for length-3 arrays).
I could have realized that earlier, when you added various capabilities to Vec3, though I'd admit that even me myself would be somewhat scared to touch gtensor right now, as it's been sitting pretty much unmaintained for quite a while...
Collaborator
Author
|
The alias thing occurred to me too, but I certainly wasn't going to touch gtensor. And yeah, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major/notable changes:
inc_curr_1vb_split